Netty Project Activities

normanmaurer pushed to master at netty/netty-website

normanmaurer — Fri, 25 May 2012 06:18:48 PDT

normanmaurer pushed to master at netty/netty-website May 25, 2012

normanmaurer committed f809f33

Get ready for 3.5.0.Beta1 release

trustin pushed to next-api at netty/netty

trustin@gmail.com (trustin) — Fri, 25 May 2012 06:17:11 PDT

trustin pushed to next-api at netty/netty May 25, 2012

trustin committed 59f11ed

Optimize AbstractChannel and related classes

- AbstractChannel.doRead() is split into two versions so that the
implementation doesn't have to validate the buffer type.
- Optimized ChannelBufferHolder a little bit
- Reduced GC related with flush future notification
- Added FlushCheckpoint and DefaultChannelFuture implements it
opportunistically
-
trustin committed 02cb7ad

Reduce GC in ChannelBuffer bulk operations

- Pre-create an NIO ByteBuffer for reuse instead of creating a new one
every time
trustin committed 2559901

Tiny bit of optimization in event loop
View comparison for these 3 commits »

normanmaurer uploaded a file to netty/netty

normanmaurer — Fri, 25 May 2012 06:16:39 PDT

normanmaurer uploaded a file to netty/netty May 25, 2012

"netty-3.5.0.Beta1-dist.tar.bz2" is at netty/netty/downloads

normanmaurer pushed to master at netty/netty-website

normanmaurer — Fri, 25 May 2012 06:14:37 PDT

normanmaurer pushed to master at netty/netty-website May 25, 2012

normanmaurer committed 402c968

Get ready for 3.5.0.Beta1 release

normanmaurer pushed to 3 at netty/netty

normanmaurer — Fri, 25 May 2012 05:56:50 PDT

normanmaurer pushed to 3 at netty/netty May 25, 2012

normanmaurer committed ae5127a

[maven-release-plugin] prepare for next development iteration

normanmaurer created tag netty-3.5.0.Beta1 at netty/netty

normanmaurer — Fri, 25 May 2012 05:56:43 PDT

normanmaurer created tag netty-3.5.0.Beta1 at netty/netty May 25, 2012

normanmaurer pushed to 3 at netty/netty

normanmaurer — Fri, 25 May 2012 05:56:43 PDT

normanmaurer pushed to 3 at netty/netty May 25, 2012

normanmaurer committed 68c1a1e

[maven-release-plugin] prepare release netty-3.5.0.Beta1

normanmaurer pushed to 3 at netty/netty

normanmaurer — Fri, 25 May 2012 05:50:38 PDT

normanmaurer pushed to 3 at netty/netty May 25, 2012

normanmaurer committed 3f3e343

[maven-release-plugin] rollback the release of netty-3.5.0.Beta1
normanmaurer committed 921e5c5

[maven-release-plugin] prepare release netty-3.5.0.Beta1
View comparison for these 2 commits »

trustin pushed to next-api at netty/netty

trustin@gmail.com (trustin) — Thu, 24 May 2012 15:17:54 PDT

trustin pushed to next-api at netty/netty May 24, 2012

trustin committed 02144f7

Genericize ChannelInitializer

trustin pushed to next-api at netty/netty

trustin@gmail.com (trustin) — Thu, 24 May 2012 10:38:08 PDT

trustin pushed to next-api at netty/netty May 24, 2012

trustin committed 4a3c54b

Add UDP_RECEIVE_PACKET_SIZE option for datagram transport
trustin committed c7c923c

Ported the QOTM example to the new API

- Fixed bugs in the NIO datagram transports
- DefaultNioDatagramChannelConfig did not initialize on Java 6
trustin committed c6f3b57

Implement NIO datagram transport with the new API

- AbstractChannel now handles flushing a message buffer
- Cleaned up DatagramChannel interface
- Removed ProtocolFamily because a user can create an NIO
DatagramChannel and specify it as a constructor parameter
- UniqueName and UniqueKey constructors became public so that
I don't need to create a subclass every time.
3 more commits »

charlesk40 commented on issue 343 on netty/netty

charlesk40 — Thu, 24 May 2012 09:39:42 PDT

charlesk40 commented on issue 343 on netty/netty May 24, 2012

Something more like which does some job for long time. class SleepHandler implements Runnable{ @Override public void run() { while (true){ //do something here try { // System.out.println('Sleeping...'); Thread.sleep(1000); } catch (InterruptedException e) { e.printStackTrace(); } } } }

charlesk40 commented on issue 343 on netty/netty

charlesk40 — Thu, 24 May 2012 09:21:11 PDT

charlesk40 commented on issue 343 on netty/netty May 24, 2012

Well, SleepHandler just mimics the handler that could take long time, and in a real handler senario, while(true) loop is a valid usage.

normanmaurer commented on issue 343 on netty/netty

normanmaurer — Thu, 24 May 2012 09:15:17 PDT

normanmaurer commented on issue 343 on netty/netty May 24, 2012

@charlesk40 the problem is that you keep the thread/cpu busy. change while(true) to : while (!Thread.interrupted()) { } And you will see it works

normanmaurer commented on issue 343 on netty/netty

normanmaurer — Thu, 24 May 2012 08:40:02 PDT

normanmaurer commented on issue 343 on netty/netty May 24, 2012

@charlesk40 Thanks! Will have a look in a few..

charlesk40 commented on issue 343 on netty/netty

charlesk40 — Thu, 24 May 2012 08:35:37 PDT

charlesk40 commented on issue 343 on netty/netty May 24, 2012

Below is a unit test that you can use to reproduce the issue. Just replace the code that generates the SSLContext. public class SslCloseTestCase { @Test public void requireThatServerCanCloseToSslIdleRequestTestCaseForNetty() throws IOException, InterruptedException { HashedWheelTimer idleTimer = new HashedWheelTimer(); ServerBootstrap sb = new ServerBootstrap(new NioServerSocketChannelFactory()); Executor channelWorkerExecutor = Executors.newCachedThreadPool(Executors.defaultThreadFactory()); SslKeyStore sslKeyStore = new SslKeyStore('src/test/resources/ssl_keystore_test.jks'); sslKeyStore.setKeyStorePassword('secret'); SSLContext sslContext = SslContextFactory.newInstance(sslKeyStore, sslKeyStore).getServerSSLContext(); SSLEngine sse = sslContext.createSSLEngine(); sse.setUseClientMode(false); sb.getPipeline().addFirst('ssl', new SslHandler(sse)); sb.getPipeline().addLast('idler',new IdleStateHandler(idleTimer, 0, 0, 40)); //Setting the idle timeout to 40 seconds. TestIdleStateAwareChannelUpstreamHandler testIdleStateAwareChannelUpstreamHandler = new TestIdleStateAwareChannelUpstreamHandler(); sb.getPipeline().addLast('handler', testIdleStateAwareChannelUpstreamHandler); channelWorkerExecutor.execute(testIdleStateAwareChannelUpstreamHandler); Channel serverChannel = sb.bind(new InetSocketAddress(0)); //Client ClientBootstrap cb = new ClientBootstrap(new NioClientSocketChannelFactory()); SslKeyStore sslKeyStoreClient = new SslKeyStore('src/test/resources/ssl_keystore_test.jks'); sslKeyStoreClient.setKeyStorePassword('secret'); SSLContext sslContextClient = SslContextFactory.newInstanceFromTrustStore(sslKeyStoreClient).getServerSSLContext(); SSLEngine sseClient = sslContextClient.createSSLEngine(); sseClient.setUseClientMode(true); cb.getPipeline().addLast('ssl', new SslHandler(sseClient)); Channel cc = cb.connect(serverChannel.getLocalAddress()).awaitUninterruptibly().getChannel(); ChannelFuture f = cc.write(ChannelBuffers.copiedBuffer('encrypted', CharsetUtil.US_ASCII)); f.await(); cc.getCloseFuture().awaitUninterruptibly(); cb.releaseExternalResources(); sb.releaseExternalResources(); } class TestIdleStateAwareChannelUpstreamHandler extends IdleStateAwareChannelUpstreamHandler implements Runnable { private volatile Channel serverChannel; private boolean readyToClose; @Override public void channelConnected(ChannelHandlerContext ctx, ChannelStateEvent e) throws Exception { // Called by Netty thread. if (serverChannel != null) { throw new IllegalStateException(); } serverChannel = ctx.getChannel(); } @Override public void messageReceived(ChannelHandlerContext ctx, MessageEvent e) { testIt(true); } private void testIt(boolean fail){ SleepHandler sleepHandler = new SleepHandler(); if (fail){ //Same thread. This LOCKS f.awaitUninterruptibly!!! sleepHandler.run(); }else{ //New thread. Passes. Executor executor = Executors.newCachedThreadPool(Executors.defaultThreadFactory()); executor.execute(sleepHandler); } } @Override public void channelIdle(ChannelHandlerContext ctx, IdleStateEvent e) throws Exception { System.out.println('Close channel'); readyToClose = true; } @Override public void run() { while(true){ if (readyToClose){ ChannelFuture f = serverChannel.close(); Assert.assertTrue(f.awaitUninterruptibly(TimeUnit.MILLISECONDS.convert(5, TimeUnit.SECONDS))); serverChannel = null; break; }else{ try { Thread.sleep(5000); } catch (InterruptedException e) { e.printStackTrace(); } } } } class SleepHandler implements Runnable{ @Override public void run() { while (true){ } } } } }

normanmaurer pushed to 3 at netty/netty

normanmaurer — Thu, 24 May 2012 07:20:39 PDT

normanmaurer pushed to 3 at netty/netty May 24, 2012

normanmaurer committed be20b50

Add a ContextBoundUnmarshallerProvider. See #324

normanmaurer pushed to 3 at netty/netty

normanmaurer — Thu, 24 May 2012 05:18:22 PDT

normanmaurer pushed to 3 at netty/netty May 24, 2012

normanmaurer committed 22282cf

Add a ThreadLocalMarshallerProvider and add test cases. See #324

normanmaurer pushed to 3 at netty/netty

normanmaurer — Thu, 24 May 2012 01:23:26 PDT

normanmaurer pushed to 3 at netty/netty May 24, 2012

normanmaurer committed cc97380

Fix class naming. See #324

normanmaurer commented on issue 360 on netty/netty

normanmaurer — Wed, 23 May 2012 23:47:51 PDT

normanmaurer commented on issue 360 on netty/netty May 24, 2012

@sunng87 thanks for the unit test and fix!

normanmaurer pushed to master at netty/netty

normanmaurer — Wed, 23 May 2012 23:47:44 PDT

normanmaurer pushed to master at netty/netty May 24, 2012

normanmaurer committed 326b88c

A small optimization for the fix of #360

normanmaurer pushed to 3 at netty/netty

normanmaurer — Wed, 23 May 2012 23:46:02 PDT

normanmaurer pushed to 3 at netty/netty May 24, 2012

normanmaurer committed 1bc52cb

Merge back fix for #360

normanmaurer pushed to master at netty/netty

normanmaurer — Wed, 23 May 2012 23:40:58 PDT

normanmaurer pushed to master at netty/netty May 24, 2012

normanmaurer committed 609caeb

Merge pull request #363 from sunng87/master

Fix #360, add check for empty string buffer
Sun Ning committed a6d7105

fix #360, add check for empty buffer; also add unit test for this scenario
View comparison for these 2 commits »

normanmaurer closed issue 360 on netty/netty

normanmaurer — Wed, 23 May 2012 23:40:56 PDT

normanmaurer closed issue 360 on netty/netty May 24, 2012

StringIndexOutOfBoundsException on ChannelBufferInputStream#readLine

normanmaurer merged pull request 363 on netty/netty

normanmaurer — Wed, 23 May 2012 23:40:56 PDT

normanmaurer merged pull request 363 on netty/netty May 24, 2012

Fix #360, add check for empty string buffer

1 commit with 13 additions and 1 deletion

sunng87 opened pull request 363 on netty/netty

sunng@about.me (sunng87) — Wed, 23 May 2012 23:35:38 PDT

sunng87 opened pull request 363 on netty/netty May 24, 2012

Fix #360, add check for empty string buffer

1 commit with 13 additions and 1 deletion

sunng87 forked netty/netty

sunng@about.me (sunng87) — Wed, 23 May 2012 17:46:42 PDT

sunng87 forked netty/netty May 24, 2012

Forked repository is at sunng87/netty

sunng87 commented on issue 360 on netty/netty

sunng@about.me (sunng87) — Wed, 23 May 2012 17:46:26 PDT

sunng87 commented on issue 360 on netty/netty May 24, 2012

@normanmaurer OK. I will send a pull request to fix this.

CruzBishop opened pull request 362 on netty/netty

cruzjbishop@gmail.com (CruzBishop) — Wed, 23 May 2012 16:19:51 PDT

CruzBishop opened pull request 362 on netty/netty May 23, 2012

Add support for reading and writing strings and sets of characters

5 commits with 254 additions and 0 deletions

normanmaurer pushed to 3 at netty/netty

normanmaurer — Wed, 23 May 2012 12:49:00 PDT

normanmaurer pushed to 3 at netty/netty May 23, 2012

normanmaurer committed 98a8bd2

Add testcases for all marshal encoder and decoder. See #324

normanmaurer pushed to 3 at netty/netty

normanmaurer — Wed, 23 May 2012 12:10:27 PDT

normanmaurer pushed to 3 at netty/netty May 23, 2012

normanmaurer committed bc30831

Rename classes to reflect the real test coverage. See #324