Shai Raiten's Blog

TFS API Part 52 – Getting Work Item History

shair — Wed, 30 Oct 2013 07:33:00 GMT

Work Item History field isn’t just a Text field that shows all the changes in a specific work items, it’s a collection of Revision object. Each time you save a Work Item a new revision object is been create and represent the Work Item Latest values.

You can use the History to get previous values from Fields, Links and Attachments history.

In this post I’ll show how to get Work Item revision list and display the Fields of specific revision.

Download Demo Project

Step 1: Connecting To TFS And Getting Work Item Store

private void btnConnect_Click(object sender, RoutedEventArgs e)
{
    TeamProjectPicker tpp = new TeamProjectPicker(TeamProjectPickerMode.NoProject, false);
    if (tpp.ShowDialog() != System.Windows.Forms.DialogResult.OK || tpp.SelectedTeamProjectCollection == null)
    {
        btnFetch.IsEnabled = txtWitId.IsEnabled = false;
        return;
    }

    tfs = tpp.SelectedTeamProjectCollection;
    store = new WorkItemStore(tfs, WorkItemStoreFlags.BypassRules);
    btnFetch.IsEnabled = txtWitId.IsEnabled = true;
}

Step 2: Getting Work Item History

Using WorkItemStore object you can get the work item, the work item object contains a Revisions collection that will allow you to navigate inside the work item history.

private void FetchWorkItemHistory()
{
    if (string.IsNullOrEmpty(txtWitId.Text)) return;

    if (!int.TryParse(txtWitId.Text, out _workitemId)) return;

    WorkItem wit = store.GetWorkItem(_workitemId);
    listRevs.ItemsSource = wit.Revisions;
}

You can also get the Work Item from specific Revision:

 WorkItem wit = store.GetWorkItem(_workitemId, rev.Index);

Download Demo Project

TFS API Part 51 – Adding Test Step & Shared Step

shair — Mon, 07 Oct 2013 06:42:00 GMT

Working TFS API for Test Cases is different from Work Items, the usage is different and this cause many of customer to send me questions regarding Test Case API.

This post will demonstrate how to create new Test Case, Adding Steps, Step Attachments, Shared Steps and more.

As always we need to start with connecting TFS Object Model:

TeamProjectPicker tpp = new TeamProjectPicker(TeamProjectPickerMode.SingleProject, false);
if (tpp.ShowDialog() != System.Windows.Forms.DialogResult.OK) return;

TfsTeamProjectCollection Tfs = tpp.SelectedTeamProjectCollection;

For Work Items we need to obtain WorkItemStore object, but for Test Cases we need to work with ITestManagmentTeamProject object.

ITestManagementServiceservice = (ITestManagementService)Tfs.GetService(typeof(ITestManagementService));
ITestManagementTeamProject TestProject = (ITestManagementTeamProject)service.GetTeamProject(tpp.SelectedProjects[0].Name);

The ITestManagmentTeamProject contains many helpers for Test API

TestPlans - Gets a helper object that provides access to the test plans in this project.
TestPoints - Contains methods to block and unblock test points.
TestResolutionStates - Gets a helper object that provides access to the test resolution states in this project.
TestResults - Gets a helper object that provides access to the test results that are shown in this project.
TestRuns - Gets a helper object that provides access to the test runs in this project.
TestSettings - Gets a helper object that provides access to the test settings in this project.
TestSuites - Gets a helper object that provides access to the test suites in this project.
TestCases - Gets a helper object that provides access to the test cases in this project.
SharedSteps - Gets a helper object that provides access to the shared steps in this project.
TestVariables - Gets a helper object that provides access to the test variables in this project.

For this post I’ll use TestCases helper to create and find new Test Case under my Team Project.

ITestCase testCase = TestProject.TestCases.Find(1);
    //  TestProject.TestCases.Query("QUery Text")
    //  TestProject.TestCases.InPlans("Query Text", isInPlans)
    //  TestProject.TestCases.Create()

Once you’ve created new Test Case you can start adding Steps and Shared Steps into the Test Case.

ITestStep newStep = testCase.CreateTestStep();
newStep.Title = "New Step Title";
newStep.ExpectedResult = "New Step Expected Result";
testCase.Actions.Add(newStep); //Don't forget adding it to the Test Actions List

ISharedStepReference sharedStepReference = testCase.CreateSharedStepReference();
sharedStepReference.SharedStepId = 2;
testCase.Actions.Add(sharedStepReference); //Don't forget adding it to the Test Actions List

//Create Test Step Attachment
ITestAttachment attachment = newStep.CreateAttachment(@"C:\Temp\Image.png");
newStep.Attachments.Add(attachment);

testCase.Save();

You can also add a bulk of test actions using ActionGroup object:

ITestStep newStep = testCase.CreateTestStep();
newStep.Title = "Step Number 1";
newStep.ExpectedResult = "New Step Expected Result";

ITestStep newStep2 = testCase.CreateTestStep();
newStep2.Title = "Step Number 2";
newStep2.ExpectedResult = "New Step Expected Result";

ITestStep newStep3 = testCase.CreateTestStep();
newStep3.Title = "Step Number 3";
newStep3.ExpectedResult = "New Step Expected Result";

ITestActionGroup group = testCase.CreateTestActionGroup();
group.Name = "Action Group";
group.Actions.Add(newStep);
group.Actions.Add(newStep2);
group.Actions.Add(newStep3);

testCase.Actions.Add(group);
testCase.Save();

Enjoy

WPF WebBrowser - getElementsByClassName Isn’t Working

shair — Wed, 02 Oct 2013 06:04:00 GMT

Working on a WPF app for a customer we’ve faced a strange problem, our WPF app display some HTML content and allow user actions on the Web Browser control – Expend and Collapsed div elements.

Because the JavaScript code is simple I don’t want to add any external library to our generated HTML and JavaScript code.

Here is how the Expend and Collapse code looks like:

function toggleAllItems(show) {
    var text = '+'; var style = 'none';
    if (show) {
        text = '-'; style = 'block';
    }
    var allexpenders = document.getElementsByClassName('expender-container');
    for (var i = 0; i < allexpenders.length; i++) {
        allexpenders[i].style.display = style;
    } 
    var toggles = document.getElementsByClassName('toggle');
    for (var i = 0; i < toggles.length; i++) {
        toggles[i].innerText = text;
    }
}
function expendAll() {
    toggleAllItems(true);
}
function collapseAll() {
    toggleAllItems(false);
}

Once I run the app I saw the HTML documents just fine except I received the following error once I clicked on the Expend\Collapsed Items. (The object is the document, get element by id works)

If I open the same HTML + JavaScript code in IE (10) it works just fine, so I had to implement the getElementByClassName

<script>
function getElementsByClassName(node, classname) {
    if (node.getElementsByClassName) {
        return node.getElementsByClassName(classname);
    }
    else {
        return (function getElementsByClass(searchClass, node) {
            if (node == null)
                node = document;
            var classElements = [];
            var tags = node.getElementsByTagName("*"), pattern = new RegExp("(^|\\s)\"+searchClass+\"(\\s|$)"), i, j;
            for (i = 0, j = 0; i < tags.length; i++) {
                if (pattern.test(tags[i].className)) {
                    classElements[j] = tags[i];
                    j++;
                }
            } return classElements;
        })(classname, node);
    }
}
</script>

Usage:

function toggleAllItems(show) {
    var text = '+'; var style = 'none';
    if (show) {
        text = '-'; style = 'block';
    }
    var allexpenders = getElementsByClassName(document, 'expender-container');
    for (var i = 0; i < allexpenders.length; i++) {
        allexpenders[i].style.display = style;
    } 
    var toggles = getElementsByClassName(document, 'toggle');
    for (var i = 0; i < toggles.length; i++) {
        toggles[i].innerText = text;
    }
}
function expendAll() {
    toggleAllItems(true);
}
function collapseAll() {
    toggleAllItems(false);
}

Visual Studio 2012 - No exports were found that match the constraint contract name

shair — Sun, 29 Sep 2013 08:44:42 GMT

For some unknown reason once I opened Visual Studio 2012 I’ve received the below error, everything worked just fined couple of days ago.

I’ve tried Visual Studio command line execution tricks but nothing, then I tried to delete the client cache and that solved the problem.

Remove ComponentModelCache folder content.

%AppData%\..\Local\Microsoft\VisualStudio\11.0\ComponentModelCache

WP8 Remove Gray Tap Highlight From Web & Mobile Apps

shair — Tue, 30 Jul 2013 05:13:00 GMT

Could not load file or assembly 'Microsoft.TeamFoundation.Client While Running Tests

shair — Thu, 25 Jul 2013 08:44:14 GMT

I know this sounds strange – What the relation between “'Microsoft.TeamFoundation.Client” and Running Tests from command line?

Visiting a customer I saw this error when the the customer tried to run Coded UI Tests using MsTest (Machine only with Test Agent):

Run has the following issue(s):
Failed to queue test run 'XX@XXX-XXXTEAM-PC 2013-07-18 17:58:02': Could not load
file or assembly 'Microsoft.TeamFoundation.Client, Version=11.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system c
annot find the file specified.

This is the line we're running:

C:\Users\XXX>mstest /testcontainer:"D:\Versions\Release\CUIT1.dll"

I've also created a dummy test dll that open calc to make sure there is not reference to TeamFoundation.Client.dll (for any reason) but the error repeats.

This is a Bug that was fixed in Update 3 for Visual Studio 2012, so just install Update 3 on the Test Agent and the problem will disappear.

Download Update 3

TFS API Part 50 – Get Team Project Template

shair — Sun, 21 Jul 2013 07:48:11 GMT

In my last post TFS 2012 Upgrade Process Template–Guide I’ve talked about upgrading an existing Team Project Template to another or a newer template.

An important part of the upgrading process is knowing from what template you are upgrading from – although this is not really important because the base template can be modified completely.

So here is a simple tool to display the Base Process Template name.

Download Demo Project

Step 1: Connect TFS and Getting Team Projects

Create WPF Application, and add the basic code for connecting TFS and collecting all Team Projects under that collection.

The below code use ICommonStructureService to retrieve all Projects under that collection.

var tpp = new TeamProjectPicker(TeamProjectPickerMode.NoProject, false);

tpp.ShowDialog();

if (tpp.SelectedTeamProjectCollection == null) return;
_tfs = tpp.SelectedTeamProjectCollection;

_ics = _tfs.GetService<ICommonStructureService>();

listProjects.ItemsSource = _ics.ListAllProjects();

Step 2: Get Team Project Details

Now once you got all the team projects under our collection, we want to get the project properties that will show us the creation process template.

private void listProjects_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
    if (listProjects.SelectedItem == null) return;

    var selectedProject = listProjects.SelectedItem as ProjectInfo;

    string name = "";
    string state = "";
    int templateId = 0;
    ProjectProperty[] projectProperties;

    _ics.GetProjectProperties(selectedProject.Uri, out name, out state, out templateId, out projectProperties);

    var properties = projectProperties.Aggregate("", (current, p) => current + string.Format("Name: {0} - Value: {1}", p.Name, p.Value));

    txtProjectDetails.Text = string.Format("Project Name: {0} \nState:{1}\n:Properties:{2}", name, state, properties);
}

Download Demo Project

TFS 2012 Upgrade Process Template–Guide

shair — Thu, 18 Jul 2013 06:12:12 GMT

Many customers are upgrading from TFS 2010 or earlier versions to TFS 2012 and in near future will upgrade to TFS 2013.

As Microsoft making the upgrade process of TFS a very smooth process there are still things we need to upgrade in our Team Project process template things that will not happened in the TFS Upgrade Process.

So which things? the Team Project Process Template – Work Items, Queries, Reports, Categories and more.

There are couple of scenarios you interesting in:

Upgrade the same Process Template to the latest version.
Change the Process Template to a different Process Template.

Upgrade the same Process Template to the latest version

To upgrade your Process Template to the latest version (After TFS Upgrade) you need to run the Feature Wizard.

If you're not a team project administrator, get permissions. Only project administrators or TFS administrators can run the wizard.
Open the administration page for your team project from a supported browser (http://ServerName:8080/tfs/CollectionName/ProjectName/_admin).
If you see a Configure Features link, run the wizard.
If you don't see this link, your features have been enabled.
If you receive a message similar to the one shown below, you can configure your team project. If more than one process template is available, accept the recommended version.
If the dialog box doesn't contain a Configure option, then you’ll need to apply the updates manually.
In most cases, the wizard will configure all the new features and you'll receive a success message.
Occasionally, the wizard will partially update your team project and return error messages that require resolution. Make a note of the errors that you receive and perform manual updates to resolve each error.

When the wizard is unable to update a team project, it will return a message indicating that there are no process templates available to support the update. Then you need to follow the second step I’ve describe below.

Change the Process Template to a different Process Template

This scenario is very popular because after upgrading from TFS 2010 to TFS 2012 many customer want to change the Current Agile Process Template to Scrum Template.

This means that you need to change the Work Items Names, Add new Work Items, Change Process Categories and more, in this post I’ll describe the main points you need to perform in order to change the Team Project Template.

First let’s open Visual Studio with TFS Administrator permission and open “Process Template Manager”.

The Process Template Manager will show you all the available templates under TFS and you can download the entire template to your local machine that contains all the information and data for the current template. In this demo I’ll download the Scrum 3.0 Template.

After the download completed (few seconds) you can browse the Process Template and see all the data that makes the process template.

Now let’s start with the Upgrade.

If you want to change the process template, let’s say from Agile to Scrum you need to change the name of “User Story” to “Product Backlog Item”, you don’t want to loose that data. (Also for Issue and Impediment)

the witadmin command line tool change a renamewitd option that changes the display name of a work item type within a specific project. After you run this command, work items of this type show the new name.

You can find the witadmin command line tool under the following path: %programfiles%\Microsoft Visual Studio 11.0\Common7\IDE

Example:

witadmin renamewitd /collection:CollectionURL /p:Project /n:TypeName /new:NewName [/noprompt]

The second part is adding new Work Item Types, you don’t want to override existing work item type (you might made some changes to the work item and override existing work items will remove you customization)

To add new Work Item Types download TFS Power Tools, this will add the Process Editor feature to you Visual Studio. The Process Editor allows you to import new work items types.

There are four Work Item Types you need to add (As part of the Agile to Scrum Upgrade)

CodeReviewRequest
CodeReviewResponse
FeedbackRequest
FeedbackResponse.

For each upgrade you need to verify what and if there is new work item types you need to add to the target project.

To Upgrade an existing Work Item Type – Such as Bug, Task Test Case etc… This require more manual work.

Once you open the Scrum, Bug template you need to start with the customizations, each custom field you add to Bug in Agile Project needs to be inside the Scrum Bug Template, some fields needs to be created also such as Microsoft.VSTS.Common.StackRank, in Scrum we are using Effort but not adding this field will cause loosing the StackRank value (After the upgrade we can copy the values from StackRank to Effort)

After you finished the Bug Template repeat the process for every work item and at the end Import the modified work items into the new project.

Finally we need to import new Categories, Adding the correct categories will start the main configuration efforts and configures which of the work item types are viable, which are hidden and which sit is which category.

witadmin importcategories /collection:http://tfs:8080/tfs /p:ProjectName /f:C:\WorkItem Tracking\categories.xml"

Finally you need to import the Agile and Common Configuration files:

witadmin importcommonprocessconfig /collection:http://tfs:8080/tfs /p:ProjectName /f:"C:\WorkItem Tracking\Process\CommonConfiguration.xml"

witadmin importagileprocessconfig /collection:http://tfs:8080/tfs /p:ProjectName /f:"C:\WorkItem Tracking\Process\AgileConfiguration.xml"

The upgrade process might require TFS Admin so the process will be successful and easy but if you still want to do yourself perform each of the describe steps and everything should be fine.

Good Luck.

מפגש ALM בנושא - All About Testing In Visual Studio 2012

shair — Thu, 06 Jun 2013 09:55:06 GMT

ראשית תודה לכל מי שהגיע למפגש ALM שהתקיים במיקרוסופט רעננה, בהרצאה זאת דיברתי על היכולות השונות לבדיקות אוטומטיות ב – Visual Studio 2012:

Unit Test ו- Fakes
Coded UI
- Advanced Search
- Cross Browser Playback
Web Performance Test
Load Testing

הורדת פרויקט דוגמא

All about testing in visual studio 2012 from Shai Raiten

מפגש קבוצת ALM בנושא אוטומציה ב–Visual Studio 2012

shair — Mon, 20 May 2013 06:06:00 GMT

בשנתיים האחרונות שאני שומע רק על Coded UI ב – Visual Studio אבל יש עוד כ”כ הרבה מעבר, במפגש הקרוב אני אדבר על כל יכולות האוטומציה ב – Visual Studio 2012 עבור מפתחים ואנשי אוטומציה.

נדבר על Unit Test ויכולת ה – Fakes החדשה שמגיעה עם Visual Studio 2012 (מחליף את Pex & Moles)
ממשק Web Test Manager שמגיע עם Update 2, אשר מאפשר עבודה עם בדיקות ללא MTM.
חידושים ודרכים יעילות לכתיבת Coded UI ועבודה עם דפדפנים שונים כגון FireFox ו – Chrome.
Web Performance Test
Load Testing

בנוסף לא כדאי להפסיד הרצאה של ליאור פרידמן שידבר על ניהול פרוייקטי Agile.

פרטים נוספים ורישום בלינק זה:

http://www.eventbrite.com/event/6729031715

אשמח לראותכם במפגש!

SignalR Isn’t Working on Samsung Galaxy 3

shair — Tue, 14 May 2013 06:16:21 GMT

I know you think the title is wired, because what is the relation between SignalR (WebSockets) and a specific device such as Samsung Galaxy 3?

ASP.NET SignalR is a new library for ASP.NET developers that makes it incredibly simple to add real-time web functionality to your applications. What is "real-time web" functionality? It's the ability to have your server-side code push content to the connected clients as it happens, in real-time.

While working on a project working with SignalR we faced a problem, the following code start the connection with the hub but the following code isn’t working, neither success or failed message appear.

$.connection.hub.start().done(function () {
alert("Connection Working!");
}).fail(function (e) {
alert("Connection Isn't Working... :-(");
});

Tried to debug the code I didn’t understand why the fail function isn’t invoked… I tired to change the transport layer to polling as part of the testing and it works……

connection.start({ transport: 'longPolling']})

I said to my self this is strange, After all Galaxy 3 supports should WebSockets and beside that this what SignalR should do if the browser isn’t supporting a specific transport layer.

From this part of I’ve understand the problem related to SignalR but still didn’t understand why that same code works on Nexus 4 and some other Android devices.

So I made the following test, I’ve open the Galaxy 3 browser and navigate to “http://www.websocket.org/echo.html” to check support for WebSockets , and surprise something isn’t working as it should – The log field didn’t showed anything (Again on different devices this works just fine).

So first thing I’ve modified jquery.signalR.js file, I’ve added a time out around the WebSockets connection, this solved the problem…

Then after a short search I found this Bug: Persistent Connection fails with IIS8 on Android Stock Browser

And this guy add his fix for the problem here - https://github.com/SignalR/SignalR/commit/6d892a3cdeb94099ed06b978ba66ec13fce521ae

You can download the fix and implementing your own timeout around the connection start.

Enjoy

VS/TFS 2012 Update 2 & Update 3 CTP

shair — Wed, 08 May 2013 06:55:20 GMT

Couple of days ago Brian Harry post about the new release of Update 2 for Visual Studio and TFS 2012, and today another release of Update 3 that isn’t big a Update 1 and 2 but contains a set of bug fixes that can ease you work.

Before jumping to Update 3, if for some reason you’re not using Update 2 this is the time to read about it and install it!

Update 2

Update 3 – CTP

Visual Studio 2012.3 (Update 3) “go-live” CTP is now available

Installing it should be relatively straight forward – for both VS and TFS, just run the installer. There should be no compatibility breaks so you need not upgrade all of your components at once, though, over time, you should plan to get them all updated

List Of Improvements – Full List

Technology improvements - Team Foundation Server

Build settings can be preserved when you upgrade a TFS 2012 instance.
Improvements are made in the New Build Definition UI for the Continuous Integration (CI) build in Git-based team projects.

Visual Studio Test

Web test

Microsoft Visual Studio 2010 crashes when you create a Web test on a computer that has both Visual Studio 2010 Service Pack 1 (SP1) and Visual Studio 2012 Update 2 installed.

Coded UI test

You cannot run coded UI together with the cross browser testing feature by using Selenium components.

Load test

When you analyze a load test run, parts of the results are missing from the graph in the default view

Unit test

783438: Mstest.exe fails to execute unit because of missing assemblies

Administration and Operations

The event log does not include stack traces when the administrator console crashes.
You cannot configure TFS proxy on a computer that belongs to a separate domain from a TFS 2012 server.
TFS 2012 backup plan wizard does not report an error when you configure a backup plan by using the Local System account.
A user who does not have read permission on an area path can receive email notifications of changes to work items under the area path.
Slow performance when you open a work item that has many customized fields in TFS Web Access.
Fix adds upload retries for Version Control files that are being checked in or shelved to reduce the number of deceptive errors.
More

Enjoy

Advanced Coded UI Testing–SDP 2013

shair — Tue, 07 May 2013 12:54:20 GMT

On Sunday I spoke about “Advanced Coded UI Testing” at Sela SDP workshops day, this was great day with many people who showed great interest in Coded UI and Automation using Visual Studio 2012. In this workshops we started from the beginning to advanced Coded UI technics and methodologies of how to write Good code for flexibility and good maintainability of your tests..

I’ve also gave some cool tools for help running Coded UI, tools like:

MS Test Runner UI – Allow everyone (with Test Agent installed) to load test files and execute tests – Good for manual testers that wants to run automated tests.
Trx to HTML converter.
Coded UI Steps Tracker
and More…

Advanced Coded UI Testing from Shai Raiten

Fifth Year as Microsoft MVP - 2013

shair — Mon, 01 Apr 2013 17:12:40 GMT

This is my fifth time as VS ALM MVP and still excited like it’s the first time I got this email:

Congratulations! We are pleased to present you with the 2013 Microsoft® MVP Award!

To be a Microsoft MVP is a great honor and I’ll keep work hard for the community: Talking and Writing about new technologies and more.

I also would like to say many thanks to my company Sela, my boss David Bassa and Caro Segal and Ishai Ram who pushed me forward in the technical community, promote many tools we built for the ALM community and helping me keep the MVP Award for another Year!

And I’ll also like to thank You, yes You! reading my blog is big part of my contribution for the community and I hope you keep reading my blog and hopefully enjoy it.

My MVP Profile - https://mvp.support.microsoft.com/profile/Shai.Raiten

פיתוח משחקים ב JavaScript - מבוסס על משחק סופר 8 - חלק 5

shair — Sun, 24 Mar 2013 10:56:42 GMT

זהו החלק האחרון בנושא סופר 8 , אני אמשיך להרחיב בנושא JavaScript ופיתוח מחשקים בכללי אבל היום אני רוצה לסגור את הדברים הבסיסיים בפיתוח משחק סופר 8.

בחלק הקודם פיתוח משחקים ב JavaScript - מבוסס על משחק סופר 8 - חלק 4 דיברנו על איך להפוך את המשחק ליותר אינטרקטיבי ע”י הוספת רקעים ואלמנטים נוספים למשחק, ראינו איך אפשר בצורה קלה ונוחה לטעון את כל הגרפיקה (ועוד) בעזרת ספריית PreloadJS ולהתחיל את המשחק כאשר קיבלנו את כל הדברים בנחוצים למשחק.

בפוסט היום נראה איך אפשר לבצע קפיצה של המשתמש (לא רק אנימציה) וכמובן אחר הנושאים החשובים ביותר- התנגשות עם אובייקטים – Collision.

לדוגמא המלאה

בהמשך מהפוסט הקודם נוסיף את הקוד הבא תחת פונקציית handleComplete על מנת לטעון אבן למשחק שלנו:

case "rock":
    var g = new createjs.Graphics()
    g.beginBitmapFill(result);
    g.drawRect(0, 0, 45, 44)
    rock = new createjs.Shape(g);
    rock.y = h - 119;
    rock.x = w;
    rock.height = 44;
    rock.width = 45;
    break;

כעת נשאר להוסיף אותה לאובייקט Stage על מנת שתופיע במשחק:

stage.addChild(sky, ground, hill, sun, player, rock);

עכשיו שיש אבן במשחק בואו נכניס אפשרות תלקפוץ מעליה, על מנת לבצע זאת נירשם ל – stagemousedown על מנת לתפוס לחיצה של העכבר של המשחק, כאשר נקבל פעולה זאת ננגן את פעולה הקפיצה ונשנה את הערך של isJumping ל – true.

נוסיף את הקוד הבא תחת פונקציית handleComplete לפני הפעלת הטיימר – setFPS.

stage.addEventListener("stagemousedown", function () {
    if (isJumping) return;
    play("jump_h");
    gameOver = false;
    isJumping = true;
});

כעת נוסיף את הקוד שישנה את מיקום הדמות על ציר Y כך שנוכל לקפוץ מעל האבן, הקוד הבא אינו הפתרון הנכון יותר אבל לדוגמא שלנו הוא פשוט ועובד, בעיקרון אפשר להוסיף הרבה קוד נוסף לביצוע פעולה זאת על ידי טיימר או מיקום הדמות אבל בשבילנו זה מספיק כרגע.

הקוד בודק שהדמות לא נמצאת באוויר (אין קפיצה כפולה), ומפעיל טיימר של שניה אחת, לאחר אותה שניה הטיימר יחזיר את הדמות לקרקע, אבל לפני זה המאפיין ה – y של השחקן יעלה ב – 4 פיקסלים כלפי מעלה עד לגובה מקסימלי, כאשר הדמות תגיע לגובה מקסימלי הדמות תתחיל בירידה כלפי מטה.

function handleJump() {
    if (isJumping) {
        if (onTheAir == null) {
            onTheAir = setTimeout(function () {
                isJumping = false;
                player.y = playerBaseY;
                onTheAir = null;
                goingDown = false;
                top = false;
            }, 1000);
        }

        if (goingDown && player.y <= playerBaseY) {
            player.y += 4;
        }
        else {
            player.y -= 4;
            if (player.y <= maxJumpHeight)
                goingDown = true;
        }
    }
}

על מנת לבצע את הקוד נוסיף קריאה לפונקציית handleJump תחת tick:

function tick() {
    handleJump();
    ...
}

כעת נוכל לבצע קפיצה בעזרת לחיצה על מקש שמאלי על המשחק.

דבר אחרון שנשאר לנו הוא להתמודד עם התנגשות של שני אובייקטים במשחק, כלומר עם השחקן יתנגש באבן אז הדמות תיפול.

ממליץ לכם לקרוא - Object/Object Intersection, ולהתעניין קצת יותר בנושא כי הוא בהחלט קצת מורכב, הרעיון המרכזי הוא לדעת מתי הדמות או אבן מתנגשות אחת בשניה, יש נוסחאות שונות לחשב את זה (תלוי גם עם הדמות מרובעות או מעגליות).

function checkRectIntersection(r1, r2) {
    var deltax = r1.x - r2.x;
    var deltay = r1.y - r2.y;
    var dist = 25;
    if (Math.abs(deltax) < dist && Math.abs(deltay) < dist) {
        if (Math.sqrt(deltax * deltax + deltay * deltay) < dist) {
            return true;
        }
    }
    return false;
}

עכשיו לחלק הקוד האחרון של המשחק, פונקציית HandleCollision אשר תקרא מתוך פונקציית tick:

function HandleCollisions() {
    var a = getCollideableItemBounds(player);
    var b = getCollideableItemBounds(rock);

    var oppss = checkRectIntersection(a, b);

    if (oppss && !gameOver) {
        console.log(oppss);
        gameOver = true;
        play("fall_h");
    }
}

וסיימנו…. כעת כאשר הדמות תגיע למרחב של האבן המשחק יעצר ודמות תיפול לרצפה, לחיצה על קפיצה תמשיך את המשחק.

לדוגמא המלאה